Add setup check to verify that the used DB version is still supported… #25016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
rullzer,
nickvergessen,
ChristophWurst and
kesselb
MorrisJobke
force-pushed
the
enh/noid/add-check-for-unsupported-db
branch
from
ba0724b to
efde9a7
Compare
MorrisJobke
commented
Jan 7, 2021
|
|
||
| public function check() { | ||
| switch (get_class($this->connection->getDatabasePlatform())) { | ||
| case MySQL80Platform::class: # extends MySQL57Platform |
There was a problem hiding this comment.
I left all the platforms in here to have the full overview (except DB2 or MSSQLServer as we don't support them at all)
nickvergessen
requested changes
Jan 7, 2021
MorrisJobke
force-pushed
the
enh/noid/add-check-for-unsupported-db
branch
2 times, most recently
from
ff94601 to
58adf13
Compare
|
Ready for review :) |
MorrisJobke
force-pushed
the
enh/noid/add-check-for-unsupported-db
branch
from
58adf13 to
834d8a5
Compare
|
/backport to stable20 |
rullzer
requested changes
Jan 8, 2021
| $version = strtolower($row['Value']); | ||
|
|
||
| if (strpos($version, 'mariadb') !== false) { | ||
| if (version_compare($version, '10.4', '<')) { |
There was a problem hiding this comment.
Suggested change
| if (version_compare($version, '10.4', '<')) { | |
| if (version_compare($version, '10.2', '<')) { |
There was a problem hiding this comment.
But 10.4 is the mysql8 compatible version?
Ref https://github.com/nextcloud/server/blob/stable16/lib/private/Setup/MySQL.php#L48-L56
There was a problem hiding this comment.
Our docs say, that 10.2 works and CI runs against 10.1 🙈
There was a problem hiding this comment.
I changed it to 10.2 for now. We can raise it later again, okay?
There was a problem hiding this comment.
10.2 is still supported so yeah :)
… in the next major release Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
enh/noid/add-check-for-unsupported-db
branch
from
834d8a5 to
bffa61f
Compare
|
@rullzer @ChristophWurst Ready for review :) |
MorrisJobke
requested review from
nickvergessen,
rullzer,
blizzz and
ChristophWurst
ChristophWurst
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in the next major release